The scope of the unsafe block can be appropriately reduced

[peamaeq]

No description provided.

[9prady9]

@peamaeq Please fix the commit message.

[9prady9]

please also address the formatting and clippy issues

[peamaeq]

please also address the formatting and clippy issues

Sorry for the long reply, thanks

[9prady9]

please also address the formatting and clippy issues

Sorry for the long reply, thanks

I am not sure which long reply you are talking about. I was referring to the commit message "0517". What does that mean ? Can you put some readable text in the commit message.

[peamaeq]

please also address the formatting and clippy issues

Sorry for the long reply, thanks

I am not sure which long reply you are talking about. I was referring to the commit message "0517". What does that mean ? Can you put some readable text in the commit message.

I'm so sorry🤦‍♂️, '0517' is date. I'm really no expert with unsafe but my understanding is that you should choose the scopes as small as possible and such that any code outside of the unsafe block can't use it's results to cause havoc. Then people only have to look at these small unsafe blocks and as long as they consider them "safe" the whole code should be safe.

[9prady9]

lgtm