Fix/150 tech detector exclude paths#170
Open
solo6760 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix tech_detector to properly exclude vendor/build directories (node_modules, build, vendor, dist) and Python cache directories when detecting primary language. This ensures repos with bundled dependencies are correctly identified by their source language rather than the bundled code.
Issue
Closes #150
Changes
_should_skip_file()method to normalize paths and filter excluded directories/node_modules/,/vendor/,/dist/,/build/,/.git/,/__pycache__/,/.venv/,/venv/\) and Unix (/) path separatorsTesting
python -m pytest tests/unit/test_tech_detector.py -vpython -m pytest tests/unit/test_tech_detector.py::TestTechDetector::test_build_directory_excluded -v) with no issues whatsoever.Notes for Reviewers
The skip pattern matching requires slashes on both sides (e.g.,
/node_modules/) to avoid false positives with similarly-named directories likenode_modules_backup. The path normalization step ensures consistent behavior across Windows and Unix systems.