fix: handle None text in context chunks for faithfulness checker (closes #153)#172
Open
gandzekas wants to merge 1 commit into
Open
fix: handle None text in context chunks for faithfulness checker (closes #153)#172gandzekas wants to merge 1 commit into
gandzekas wants to merge 1 commit into
Conversation
The method used which returns when the key exists with value (default only applies to missing keys). This caused when joining with . Fix: Use to normalize to empty string. Closes ascherj#153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #153
The
FaithfulnessChecker.check()method usedchunk.get("text", "")to extract text from context chunks. However, when the key"text"exists but its value isNone,.get()returnsNone(the default only applies to missing keys). This caused aTypeErrorwhen" ".join(...)tried to joinNonevalues.Fix: Changed to
chunk.get("text") or ""which normalizesNoneto empty string.Test: The existing test
test_none_context_chunk_textintests/unit/test_faithfulness_checker.pynow passes.Closes #153