Fix health check: SQLAlchemy 2.x compatibility and Redis host config#173
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
Fix health check: SQLAlchemy 2.x compatibility and Redis host config#173fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
…e-aware alternatives
fazalpsinfo-cmyk
force-pushed
the
fix/sqlalchemy-redis-health-fixes
branch
from
July 17, 2026 08:08
e71a033 to
9fcbd21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two bugs in the health check endpoint:
Fix #154 - SQLAlchemy 2.x raw SQL
Wrapped the raw
"SELECT 1"string withsqlalchemy.text()for SQLAlchemy 2.x compatibility. SQLAlchemy 2.x requires textual SQL expressions to be explicitly declared astext('SELECT 1').Fix #155 - Missing redis_host/redis_port config
Replaced references to
settings.redis_hostandsettings.redis_port(which don't exist on the Settings model) withsettings.redis_url, parsing the hostname and port from the existingredis_urlconfiguration field.Related Issues
Closes #154
Closes #155
If you found this useful, consider buying me a coffee: https://buymeacoffee.com/muhamedfazalps