fix: wrap sync task in Flask application context#615
Open
dahagag wants to merge 1 commit into
Open
Conversation
The sync task was failing to commit database changes because it was executing outside of the Flask application context. This caused RuntimeError when trying to mark emails as synced after upload. Added app_context() wrapper to ensure proper SQLAlchemy session handling during database operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The celery sync task was failing silently with a RuntimeError when trying to commit database changes:
This happens because the async task executes outside of Flask's application context. When
_mark_as_synced()tries to commit viadb.session.commit(), Flask-SQLAlchemy needs an active application context to function.Root Cause
Celery worker processes run independently from the Flask application. Database operations that depend on Flask-SQLAlchemy's request/app context must be explicitly wrapped.
Solution
Wrap the sync task execution in a Flask application context using
with webapp.app_context():. This ensures SQLAlchemy session handling works correctly during database operations.Changes
sync()task intasks.pyto wrap all operations inwebapp.app_context()Testing
Related
Complements systemctl service restart fix in PR #614