Remove unnecessary redefinitions of uint*_t types#219
Open
ptrcnull wants to merge 1 commit intoasg017:mainfrom
Open
Remove unnecessary redefinitions of uint*_t types#219ptrcnull wants to merge 1 commit intoasg017:mainfrom
ptrcnull wants to merge 1 commit intoasg017:mainfrom
Conversation
while the spec (ISO 9899:1999, 7.18.1.1) makes these typedefs optional, in practice they are defined in <stdint.h> for all supported platforms; types u_int*_t are BSDisms and might not exist, making the typedefs fail with `error: unknown type name ‘u_int8_t’`, e.g. on Solaris or musl libc
Author
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 13, 2025
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 14, 2025
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
see also: https://phabricator.services.mozilla.com/D247229#8557917 asg017/sqlite-vec#219 Differential Revision: https://phabricator.services.mozilla.com/D248399 UltraBlame original commit: 98761001f9bde7c92c1a50a78328ac3993929563
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
see also: https://phabricator.services.mozilla.com/D247229#8557917 asg017/sqlite-vec#219 Differential Revision: https://phabricator.services.mozilla.com/D248399 UltraBlame original commit: 98761001f9bde7c92c1a50a78328ac3993929563
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
see also: https://phabricator.services.mozilla.com/D247229#8557917 asg017/sqlite-vec#219 Differential Revision: https://phabricator.services.mozilla.com/D248399 UltraBlame original commit: 98761001f9bde7c92c1a50a78328ac3993929563
ziyao233
pushed a commit
to ziyao233/eweos-packages
that referenced
this pull request
May 31, 2025
Add a downstream patch to fix building failures of third-party library sqlite-vec. Link: asg017/sqlite-vec#219 Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1962061 Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1964446
ziyao233
pushed a commit
to eweOS/packages
that referenced
this pull request
May 31, 2025
Add a downstream patch to fix building failures of third-party library sqlite-vec. Link: asg017/sqlite-vec#219 Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1962061 Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1964446
|
Are there any plans to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while the spec (ISO 9899:1999, 7.18.1.1) makes these typedefs optional, in practice they are defined in <stdint.h> for all supported platforms
meanwhile, types u_int*_t are BSDisms and might not exist, making the typedefs fail with
error: unknown type name ‘u_int8_t’, e.g. on Solaris or musl libc