Restructuring, getting rid of more memory leaks, and improving readability#70
Open
polterguy wants to merge 66 commits intoasg017:mainfrom
Open
Restructuring, getting rid of more memory leaks, and improving readability#70polterguy wants to merge 66 commits intoasg017:mainfrom
polterguy wants to merge 66 commits intoasg017:mainfrom
Conversation
Moving concepts into separate files
This reverts commit bcef4f3.
Getting ready for applying read/write locks
Hopefully synchronising access correctly and cleaning up stuff ;)
Library is loaded for each connection, so static members doesn't last
This reverts commit aadc50b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much better structure. Among some of the things I have done are;
SqlStatementclass encapsulating all SQL statements executed towards SQLitevss_indexclass, moving parts it should be responsible for into it as methodsMore work needs to be done, especially on the "xyz.h" files, that really should have associated "xyz.cpp" files, but at least it's a start. I tried to implement memory cache on the faiss indexes, and I had everything working, but didn't understand why the cache mechanism didn't work, until I realised SQLite will dynamically load the library on every connection, resulting in that my static
std::mapwould be deleted, and hence my approach to caching was useless. I removed these parts, but you can see the idea in the history if interested.Psst, you'll have to check out the branch in its entirety. There's no way you can make sense of the pull request by looking at the diff.