fix(mqtt): stop no longer leaks the shared connection driver#10
Merged
Conversation
When a shared MQTT connection was torn down while the broker was unreachable, the client's request queue could be full (inject kept publishing), so `disconnect().await` blocked. The node then missed the graceful window and was aborted before stopping the connection's driver task — which kept reconnecting and emitting errors, so Stop appeared to do nothing. Time-bound the graceful close (500ms) and always abort the driver after, so Stop reliably tears the connection down. Verified: Stop returns in ~0.5s and errors cease (previously hung 2s and kept erroring).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shared MQTT connection was torn down while the broker was unreachable, the client's request queue could be full (inject kept publishing), so
disconnect().awaitblocked. The node then missed the graceful window and was aborted before stopping the connection's driver task — which kept reconnecting and emitting errors, so Stop appeared to do nothing.Time-bound the graceful close (500ms) and always abort the driver after, so Stop reliably tears the connection down. Verified: Stop returns in ~0.5s and errors cease (previously hung 2s and kept erroring).