fix(modbus-slave): abort the server task on stop#11
Merged
Conversation
The slave spawned its TCP/RTU server as a detached task that outlived the node, so stopping or redeploying left the listener bound — a redeploy on the same port then failed and an orphan server kept serving the old map. Hold the server task in an AbortOnDrop guard so it is aborted when the node stops. Verified: stop + redeploy on the same port rebinds cleanly (no bind_error; previously the port stayed held).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slave spawned its TCP/RTU server as a detached task that outlived the node, so stopping or redeploying left the listener bound — a redeploy on the same port then failed and an orphan server kept serving the old map.
Hold the server task in an AbortOnDrop guard so it is aborted when the node stops. Verified: stop + redeploy on the same port rebinds cleanly (no bind_error; previously the port stayed held).