Repository navigation
fix: correct generated provider launchers and asset roots - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated provider applications did not pass APP_ORIGIN and its host to the Node transport, omitted Node types in several starters, and served assets relative to the wrong directory after the server bundle moved into dist/server.
Wire the configured origin and host into all four provider-capable launchers, include Node types once, and resolve browser assets from dist. Exclude server bundles and Vite manifests while preserving public paths such as /server-status. The SSR and full-stack templates share the corrected asset setup.
All four generated-launcher regressions fail before the fix and pass afterward. The tests execute each generated launcher from its production output directory and verify its transport options and asset exclusions. All 20 provider generator tests, formatting, and the full
npm run checkpass, including 590 coverage tests, docs, declarations, publint, and installed package consumers. All five packed templates also pass with ordinary public-registry installs (118 seconds). The minimum-peer check and all 22 CLI benchmark budgets pass.Extracts the behavior changes from #188 while retaining published dependency ranges and existing workflows.