Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a56315940
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # absolute-path → manifest-path fixup in pytest_main.py should have | ||
| # rewritten coverage.py's follow-symlinks absolute path back to the | ||
| # original "examples/pytest/foo.py" entry. | ||
| grep -qE '^SF:.*examples/pytest/foo\.py$' "$LCOV" || { |
There was a problem hiding this comment.
The SF check is too permissive: ^SF:.*examples/pytest/foo\.py$ will still match an unfixed absolute path like SF:/tmp/.../examples/pytest/foo.py, so this test can pass even if the absolute→manifest rewrite in pytest_main.py regresses. That weakens the regression coverage this script is intended to provide; matching the exact manifest path would make the test fail when the fixup is broken.
Useful? React with 👍 / 👎.
2 participants
Add some tests now so #944 highlights changes
Changes are visible to end-users: no
Test plan