Separate args into groups#152
Merged
Merged
Conversation
typescript-node cannot emit docs on its own, so models.ts, the docs and the README were produced by a second generator invocation that reused the api.ts/git_push.sh/tsconfig.json output slots. Emit them as user-defined supporting files (config-node.json "files" section) so everything is produced in one run, and rename the templates to match their output.
These generators produced a file under an unrelated built-in name (git_push.sh, appveyor.yml, response.go) and moved it into place. Emit each at its real name via the config "files" section and rename the templates to match. For Go, drop the generator's default response.go before the wildcard move so it is not pulled into the SDK.
Emit gradle.properties, app/build.gradle and MainActivity.kt via the files config instead of hijacking the git_push.sh/gradlew/ApiException.java slots (settings.gradle overrides the built-in template directly). Update the MainActivity and README sample to the grouped generate() API (barcodeImageParams/qrParams) to match the current SDK.
Replace the Go Report Card badge with the pkg.go.dev Go Reference badge for the v4 module, and point the CI status badge at the v4 branch.
utils.go shipped only unused openapi-generator helpers (Ptr*, Nullable*, IsNil, newStrictDecoder). Emit an empty utils.go from a trimmed template.
Previously only ?branch=main passed. Accept ?branch=main or ?branch=v4 (the Go SDK's default branch); flag any other branch, a missing branch, or prefixes like v40.
The API now serves the x-param-group vendor extensions itself, so inject-param-groups.py only re-serialised the fetched JSON ({ } -> {}, trailing newline), drifting the committed spec from live and failing the check-swagger CI job on every 'make update'. Remove the script and its callers (update_swagger_spec.bash, the Makefile spec-param-groups target); the fetched spec needs no post-processing.
Add the reserved .example TLD to the URL checker's ignore list; also apply isort/black formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.