Skip to content

OUT-4184: run lint only on pull_request - #290

Merged
SandipBajracharya merged 1 commit into
masterfrom
OUT-4184-lint-pull-request
Sep 15, 2026
Merged

SandipBajracharya merged 1 commit into
masterfrom
OUT-4184-lint-pull-request

Conversation

@SandipBajracharya

Copy link
Copy Markdown
Collaborator

What

Scope the Lint workflow to pull_request only (was on: push).

Why

deploy.yml (merged in #288/#289) runs a lint job on every merge to master, so the push-triggered Lint workflow was redundant on master and double-running on every branch push. test.yml is already pull_request-only; this brings lint.yml in line.

Effect

  • PRs are still fully linted (pull_request fires on open/synchronize).
  • No more duplicate lint run on master merges — deploy.yml covers those.
  • Branches without an open PR no longer trigger a standalone lint run (they get linted when a PR is opened).

🤖 Generated with Claude Code

Merges to master are now linted by deploy.yml's lint job, so the
push-triggered Lint workflow was redundant on master and on every branch
push. Scope it to pull_request, matching test.yml.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
quickbooks-sync Building Building Sep 15, 2026 10:00am UTC
quickbooks-sync (dev) Ready Ready Preview Sep 15, 2026 10:00am UTC

Request Review

@linear-code

linear-code Bot commented Sep 15, 2026

Copy link
Copy Markdown

OUT-4184

@SandipBajracharya SandipBajracharya changed the title chore(OUT-4184): run lint only on pull_request OUT-4184: run lint only on pull_request Sep 15, 2026
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

This PR appears safe to merge.

What we checked:

  • Master deploy could skip lint: No. deploy.yml runs the same lint and Prettier checks on pushes to master. Its deploy job waits for lint to pass.

Summary

The Lint workflow now runs only for pull requests instead of every push. Merges to master continue to be linted by deploy.yml, so duplicate lint runs are removed.

  • Pull requests still run the full lint checks.
  • Branch pushes without an open pull request no longer start a standalone lint run.

Diagram

sequenceDiagram
    actor Dev as Developer
    participant GH as GitHub Actions
    participant Lint as Lint workflow
    participant Deploy as Deploy workflow

    alt Pull request opened, updated, or reopened
        Dev->>GH: Change pull request
        GH->>Lint: Trigger pull_request
        Lint->>Lint: Install dependencies
        Lint->>Lint: Run lint and Prettier checks
        Lint-->>GH: Report result
    else Push to master
        Dev->>GH: Push or merge commit
        GH->>Deploy: Trigger push to master
        Deploy->>Deploy: Run lint and Prettier checks
        Deploy->>Deploy: Wait for typecheck, test, and lint
        Deploy-->>GH: Deploy only after checks pass
    else Push to branch without a pull request
        Dev->>GH: Push commit
        Note over GH: No standalone lint run
    end
Loading

Reviews (1) · Last reviewed commit: "chore(OUT-4184): run lint only on pull_r..."

@SandipBajracharya
SandipBajracharya merged commit 54cf027 into master Sep 15, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
dev — d0ccd442 Deployed Sep 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant