Repository navigation
refactor: rename identity.WithCaller to identity.NewContext - #10
Merged
ajbeck merged 1 commit intoSep 27, 2026
Merged
Conversation
Pair the context installer with FromContext, following the Go blog's NewContext/FromContext convention. Every other With function in the module is a functional option. The signature, conflict detection and nil-context handling are unchanged. BREAKING CHANGE: identity.WithCaller is now identity.NewContext.
ajbeck
added this pull request to stack #7
September 27, 2026 14:36
ajbeck
marked this pull request as ready for review
September 27, 2026 15:05
ajbeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements E3. Renames
identity.WithCallertoidentity.NewContext, pairing it withFromContextas in the Go blog's context convention. The signature, conflict detection and nil-context handling are unchanged. Every call site, the runnable example (nowExampleNewContext) and the guides are updated, and decision 0012 gets a dated note.Part of decision 0026, approved by the owner; stacked on #9.
Validation
gofmt,
go vet ./...,go mod verify,go test -race ./...,sh scripts/check-consumer.sh, Linux arm64/amd64 builds andgit diff --checkall pass locally on Go 1.27.1.Breaking: the function name changes.