Repository navigation
fix(ci): streamline releases and use organization App secrets - #2
Merged
Merged
Conversation
ajbeck
changed the title
ajbeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Please repeated the Go validation matrix after every merge, then failed before release execution because the original App had no installation for this repository.
Run Go validation only on PRs against main, including generated release PRs. Main pushes now run only release automation. Remove the unused reusable-workflow entry point.
Use the newly installed astrocompute-release-please App through organization Actions secrets RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY. Both secrets are provisioned with selected-repository access for go-lambda-edge; the obsolete repository credentials were removed so they cannot override the organization credentials. Both workflow inputs now use the secrets context.
Validation: both workflows pass actionlint and git diff --check. Read-only App-authenticated API calls verified that the supplied key and Client ID match the installed App, repository access is present, and Contents, Issues and Pull requests have write permissions. Organization secret metadata and selected repository access were verified without displaying credentials. End-to-end token creation and Release Please execution remain to be verified after merge.
Existing PR test/build jobs and scoped App permissions remain in place. Direct main pushes do not run Go validation. No release has been published.