This repository was archived by the owner on Feb 16, 2024. It is now read-only.
Added loadURL and setProxy functionality#41
Open
true-zero wants to merge 5 commits intoasticode:masterfrom
true-zero:master
Open
Added loadURL and setProxy functionality#41true-zero wants to merge 5 commits intoasticode:masterfrom true-zero:master
loadURL and setProxy functionality#41true-zero wants to merge 5 commits intoasticode:masterfrom
true-zero:master
Conversation
asticode
suggested changes
Feb 3, 2021
| .then(() => client.write(json.targetID, consts.eventNames.windowEventWebContentsExecutedJavaScript)); | ||
| break; | ||
| case consts.eventNames.windowCmdWebContentsSetProxy: | ||
| elements[json.targetID].webContents.session.clearAuthCache().then(() => { |
Owner
There was a problem hiding this comment.
I don't really like the fact of clearing the Session Auth Cache here.
It should be split into 2 different events, one for clearing the auth cache and another one to set the proxy.
Contributor
Author
There was a problem hiding this comment.
I disagree since when you re-set the proxy you don't want it to try use the same credentials (for instance, when using a rotating proxy IP), the behaviour in Electron is what is strange.
Owner
There was a problem hiding this comment.
Thing is, it makes sense in your case, but not in others. Clearing auth cache shouldn't be binded to setting the proxy simply to allow developers to do one without the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.