Skip to content

Skip BOLT optimization for HACL hash compressors #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
Jul 22, 2026
+5 −1
Merged

Skip BOLT optimization for HACL hash compressors #1187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cpython-unix/build-cpython.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,11 @@ if [ -n "${CPYTHON_OPTIMIZED}" ]; then
# https://github.com/python/cpython/issues/128514
# https://github.com/python/cpython/pull/134642
# https://github.com/llvm/llvm-project/issues/174191
BOLT_COMMON_FLAGS="-update-debug-sections -skip-funcs=RC4_options/1"
# BOLT's allocation combiner can remove required stack allocations in
# the HACL hash compressors, leaving frame-pointer-relative accesses
# below the x86-64 red zone. Match BOLT's `/N` suffix for local symbols.
# https://github.com/astral-sh/uv/issues/20618

@zanieb zanieb Jul 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# https://github.com/astral-sh/uv/issues/20618
# https://github.com/astral-sh/python-build-standalone/issues/1186

BOLT_COMMON_FLAGS="-update-debug-sections -skip-funcs=RC4_options/1,sha256_update/.*,sha512_update/.*,PyBlake2_blake2b_compress/.*,PyBlake2_blake2s_compress/.*,update_block.*"
BOLT_APPLY_FLAGS="${BOLT_COMMON_FLAGS} \
-reorder-blocks=ext-tsp \
-reorder-functions=cdsort \
Expand Down
Loading