Repository navigation
build(test): a test class that leaves no result fails the build (#9) - #10
Merged
Merged
Conversation
gradle/test-results-complete.gradle, the check of astrapi69/swing-components#34 in its fourth version: after every test task, each compiled test class must have left a result, or the build fails and names it. A test that ends the test JVM no longer passes as green. Measured before the change, in a scratch clone: all 3 test classes left a result. Closes #9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10 +/- ##
==========================================
Coverage 88.88% 88.88%
Complexity 16 16
==========================================
Files 3 3
Lines 54 54
Branches 3 3
==========================================
Hits 48 48
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Adds
gradle/test-results-complete.gradle, the check of astrapi69/swing-components#34 in its fourth version, and applies it to every test task: a compiled test class that leaves no result fails the build and is named. A test that ends the test JVM (System.exit) can then no longer let the build report green over test classes that never ran.Measured on the default branch with the check applied,
./gradlew test --rerunon an Xvfb of its own: all 3 test classes left a result. CI on this pull request is the run on the real build.