Repository navigation
fix(proxmox): observe live VM config without false drift - #158
Merged
Merged
Conversation
Decode numeric configuration strings and propagate failed configuration reads. Observe native VM settings and use provider-owned comparison semantics across Get, List, Watch, and reconciliation, excluding creation-only and write-only inputs while preserving real drift. Cover numeric decoding, configuration outages, keyed device comparison, and automatic reconciliation with regressions. Verified with repository/plugin tests, focused race tests, a full build, and read-only Get/List against the homelab dev-system VM.
Use CutPrefix, SplitSeq, FieldsSeq, and slices.Contains in native VM observation. Replace the existing graph capacity expression with equivalent slices.Clip to satisfy the current analyzer. Verified Proxmox, operation graph, and controller server regressions.
Keep the pull context alive until cleanup acquires the repository lock, then cancel while no git command can be in flight. This prevents temporary directory removal from racing background writes without changing GitOps production behavior. Verified the periodic-pull scenario with 20 race-enabled runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification