Skip to content

Add back astropy-credits page - #742

Merged
eteq merged 3 commits into
astropy:mainfrom
Cadair:credits-restore
Oct 1, 2026
Merged

eteq merged 3 commits into
astropy:mainfrom
Cadair:credits-restore

Conversation

@Cadair

@Cadair Cadair commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

closes #709

@pllim pllim added the Bug label Sep 29, 2026
@Cadair
Cadair marked this pull request as ready for review September 30, 2026 09:28
@Cadair

Cadair commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

@eteq @pllim this is ready for a review.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't review the contents word-by-word carefully, as I assume you copy-pasted it from the lost document that was already vetted, but the overall vibes look good.

Comment thread team.rst Outdated
Comment thread conf.py
urlretrieve(
"https://raw.githubusercontent.com/astropy/astropy/refs/heads/main/docs/credits.rst",
filename="credits.rst",
filename="core-credits.rst",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So was this the problem somehow?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the origin of this is that we had two subtly different "credits" pages previously - the one taken basically from the core package, and the broader one that covers the whole project. Instead of merging them in the change, we just dropped one in favor of the other (which was wrong of course, but not obvious at the time)

@pllim
pllim requested review from eteq and hamogu September 30, 2026 15:51
@pllim

pllim commented Sep 30, 2026

Copy link
Copy Markdown
Member

linkcheck failure is unrelated

Comment thread team.rst
=======================
-----------------------

- E. Madison Bray

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I guess the changes here didn't make it worse... https://www.astropy.org/team.html#emeritus-voting-members

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

@eteq eteq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good starting point since it restores all of the content ASAP, so I'm going to go ahead and merge this now. But I do think we want to re-organize a bit, so I will make a follow-up issue about that.

@eteq
eteq merged commit ab250b4 into astropy:main Oct 1, 2026
6 of 7 checks passed
@Cadair
Cadair deleted the credits-restore branch October 1, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credits page is missing

3 participants