Add use_ellipse keyword to circle to_sky and to_pixel methods#652
Open
larrybradley wants to merge 6 commits intoastropy:mainfrom
Open
Add use_ellipse keyword to circle to_sky and to_pixel methods#652larrybradley wants to merge 6 commits intoastropy:mainfrom
larrybradley wants to merge 6 commits intoastropy:mainfrom
Conversation
larrybradley
force-pushed
the
circle-to_ellipse
branch
from
c0acceb to
b075878
Compare
larrybradley
force-pushed
the
circle-to_ellipse
branch
from
b075878 to
60bebd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I'm currently immersed in WCS transformations, here's one final (optional) improvement for circular region sky/pixel conversions. This PR adds a
use_ellipsekeyword to theto_pixelandto_skymethods of circular and circular annulus region classes that allows the user to specify whether to return an elliptical region instead of a circular region when converting between pixel and sky coordinates. This is useful for cases where the WCS is distorted or has different pixel scales along different axes and the circular region would be significantly distorted in pixel or sky coordinates.Example:
The polygon -> polygon conversion represents "truth", which matches the new optional circle -> ellipse conversion.