Skip to content

Remove redundant plugin tests #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
athackst merged 1 commit into from
Aug 13, 2026
Merged

Remove redundant plugin tests #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions tests/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,6 @@ def test_default_include_preserves_navigation_files(self):
self.assertIn(".pages", plugin.config["include"])
self.assertIn(".nav.yml", plugin.config["include"])

def test_on_startup_records_dirty_mode(self):
"""Test startup passes the dirty-build state to file generation."""
plugin = self.make_plugin()

plugin.on_startup(command="serve", dirty=True)

self.assertTrue(plugin.dirty)

def test_on_config_merges_into_docs_directory(self):
"""Test the default configuration builds into the docs directory."""
plugin = self.make_plugin()
Expand All @@ -77,7 +69,6 @@ def test_on_config_merges_into_docs_directory(self):
self.assertEqual(docs_dir, plugin.orig_docs_dir)
self.assertEqual(docs_dir, plugin.config["build_dir"])
self.assertEqual(docs_dir, config["docs_dir"])
self.assertIn(".nav.yml", plugin.config["include"])
self.assertIn(docs_dir, plugin.config["ignore_paths"])
self.assertIn(site_dir, plugin.config["ignore_paths"])
self.assertIn("include:", config["mkdocs_simple_config"])
Expand All @@ -102,7 +93,7 @@ def test_on_config_uses_temporary_directory_without_merge(self):
def test_on_files_replaces_existing_file_with_generated_file(self):
"""Test generated documentation replaces the original MkDocs file."""
plugin = self.make_plugin()
plugin.dirty = True
plugin.on_startup(command="serve", dirty=True)
plugin.last_build_time = 10
temporary_directory = tempfile.TemporaryDirectory()
self.addCleanup(temporary_directory.cleanup)
Expand Down
3 changes: 1 addition & 2 deletions tests/test_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,8 @@ def test_is_doc_file(self):
self.assertTrue(simple_test.is_doc_file(name="helloworld.md"))
self.assertFalse(simple_test.is_doc_file(name="md.helloworld"))

simple_test.doc_glob = [".pages", ".nav.yml"]
simple_test.doc_glob = [".pages"]
self.assertTrue(simple_test.is_doc_file(name=".pages"))
self.assertTrue(simple_test.is_doc_file(name=".nav.yml"))

def test_get_files(self):
"""Test getting all files."""
Expand Down