Skip to content

collect console log in renderer tests #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aminya merged 2 commits into from
Jul 25, 2020
Merged

collect console log in renderer tests #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c413a56
collect console log in renderer tests
aminya Jul 25, 2020
3bdd637
Use async.series
aminya Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions script/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,21 @@ for (let testFile of testFiles) {
'--resource-path', resourcePath,
'--test', testFile
]
const cp = childProcess.spawn(executablePath, testArguments, {stdio: 'inherit', env: testEnv})
cp.on('error', error => { callback(error) })
cp.on('close', exitCode => { callback(null, {exitCode, step: `core-render-process for ${testFile}.`, testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`}) })
const cp = childProcess.spawn(executablePath, testArguments, { env: testEnv})
let stderrOutput = ''
cp.stderr.on('data', data => { stderrOutput += data })
cp.stdout.on('data', data => { stderrOutput += data })
cp.on('error', error => {
console.log(error, "error")
callback(error)
})
cp.on('close', exitCode => {
if (exitCode !== 0) {
console.log(`##[error] Renderer tests failed for ${testFile}:`.red)
console.log(stderrOutput)
}
callback(null, {exitCode, step: `core-render-process for ${testFile}.`, testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`})
})
})
}

Expand Down Expand Up @@ -269,7 +281,7 @@ function requestedTestSuites (platform) {
return suites
}

async.parallel(testSuitesToRun, function (err, results) {
async.series(testSuitesToRun, function (err, results) {
if (err) {
console.error(err)
process.exit(1)
Expand Down