collect console log in renderer tests

script/test

@@ -110,9 +110,21 @@ for (let testFile of testFiles) {
       '--resource-path', resourcePath,
       '--test', testFile
     ]
-    const cp = childProcess.spawn(executablePath, testArguments, {stdio: 'inherit', env: testEnv})
-    cp.on('error', error => { callback(error) })
-    cp.on('close', exitCode => { callback(null, {exitCode, step: `core-render-process for ${testFile}.`, testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`}) })
+    const cp = childProcess.spawn(executablePath, testArguments, { env: testEnv})
+    let stderrOutput = ''
+    cp.stderr.on('data', data => { stderrOutput += data })
+    cp.stdout.on('data', data => { stderrOutput += data })
+    cp.on('error', error => {
+      console.log(error, "error")
+      callback(error)
+    })
+    cp.on('close', exitCode => {
+      if (exitCode !== 0) {
+        console.log(`##[error] Renderer tests failed for ${testFile}:`.red)
+        console.log(stderrOutput)
+      }
+       callback(null, {exitCode, step: `core-render-process for ${testFile}.`, testCommand: `You can run the test again using: \n\t ${executablePath} ${testArguments.join(' ')}`})
+     })
   })
 }
 
@@ -269,7 +281,7 @@ function requestedTestSuites (platform) {
   return suites
 }
 
-async.parallel(testSuitesToRun, function (err, results) {
+async.series(testSuitesToRun, function (err, results) {
   if (err) {
     console.error(err)
     process.exit(1)

script/vsts/platforms/templates/bootstrap.yml

@@ -28,4 +28,4 @@ steps:
       GITHUB_TOKEN: $(GITHUB_TOKEN)
       CI: true
       CI_PROVIDER: VSTS
-      condition: or(ne(variables['MainNodeModulesRestored'], 'true'), ne(variables['ScriptNodeModulesRestored'], 'true'), ne(variables['ApmNodeModulesRestored'], 'true'))
+    condition: or(ne(variables['MainNodeModulesRestored'], 'true'), ne(variables['ScriptNodeModulesRestored'], 'true'), ne(variables['ApmNodeModulesRestored'], 'true'))

script/vsts/platforms/templates/test.yml

@@ -51,7 +51,7 @@ steps:
 
   # Crash Reports
   - pwsh: |
-      mkdir -f -p $env:ARTIFACT_STAGING_DIR/crash-reports
+      New-Item -Path $env:ARTIFACT_STAGING_DIR/crash-reports -Type Directory -Force
       if (($env:AGENT_OS -eq "Windows_NT") -and (Test-Path "$env:TEMP/Atom Crashes")) {
         cp "$env:TEMP/Atom Crashes/*.dmp"  $env:ARTIFACT_STAGING_DIR/crash-reports
       } else {

script/vsts/platforms/windows.yml

@@ -1,5 +1,5 @@
 jobs:
-  - job: Windows_Build
+  - job: Windows
     dependsOn: GetReleaseVersion
     timeoutInMinutes: 180
     strategy:
@@ -71,7 +71,7 @@ jobs:
               condition: and(succeeded(), eq(variables['IsReleaseBranch'], 'true'))
 
   - job: Windows_RendererTests
-    dependsOn: Windows_Build
+    dependsOn: Windows
     timeoutInMinutes: 180
     strategy:
       maxParallel: 2