Conversation
aminya
changed the title
Member
|
This seems good to me. 👍 Technical note: Not just GitHub, but Git itself will think this has a huge diff. So sadly this small change can expose us to merge conflicts. It is what it is, no real way around it, other than hopefully upstreaming this eventually. Edit to add: Everything we do can expose us to merge conflicts. It's no big deal; if we understand how the code works, merge conflicts are easy to solve. |
aminya
force-pushed
the
test-performance
branch
from
e6db3c9 to
499f34b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test: create the renderer and package test only if needed. This speeds up test env preparation.
Verification
Just wraps the code in functions.
Continuation of #50