Fix stored-truth category qualification and reduce passport churn on generate#29
Merged
Conversation
added 24 commits
May 22, 2026 23:22
Spenquatch
marked this pull request as ready for review
May 25, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
descriptor_idvalues, so read-side surfaces keep stored truth instead of minting fresher category qualification.status,export, benchmark snapshots, and passport-preserving rebuilds.spec generateidempotent for unchanged tracked passports by skipping timestamp-only rewrites, which keeps the ecommerce example clean on repeated checks.Testing
cargo test -p spec-core semantic_reviewcargo test -p spec-core passportcargo test -p spec-cli benchmark_read_surfaces_do_not_backfill_missing_supported_seam_descriptor_ids -- --exactcargo test -p spec-cli spec_generate_second_run_keeps_tracked_passport_bytes_when_nothing_changedcargo test -p spec-cli status_benchmark_root_contract_matches_frozen_fixture -- --exactcargo test -p spec-cli export_benchmark_root_contract_matches_frozen_fixture -- --exactcargo test -p spec-cli benchmark_snapshot_writes_seeded_positive_negative_and_reserved_outputs -- --exactcargo fmt --all