Fix esp32 build to use ATOMVM_ELIXIR_SUPPORT#75
Open
petermm wants to merge 4 commits into
Open
Conversation
Signed-off-by: Peter M <petermm@gmail.com>
Pass -DATOMVM_ELIXIR_SUPPORT=on when configuring the ESP-IDF target so current AtomVM selects the Elixir partition table and boot library through CMake. Remove the older sdkconfig.defaults mutation, reconfigure step, and mkimage.sh --boot flow. Invoke mkimage.erl directly, normalize Docker-generated /project paths for local execution, and allow custom mkimage.config boot entries while rejecting stale stock esp32boot configs. Signed-off-by: Peter M <petermm@gmail.com>
Suggest get_idf or running the export script. Signed-off-by: Peter M <petermm@gmail.com>
Localize Docker-generated mkimage.config /project paths only for Docker builds, escape host paths inserted into the Erlang config string, and verify mkimage actually produced a non-empty image before reporting success. Fail fast when escript is missing instead of after the build. Add AtomVMBuilder.clean_dir/1 to tolerate the macOS race where .DS_Store is recreated mid-delete, which made File.rm_rf! crash --clean builds, and use it for all build-directory cleanups. Require Elixir 1.18. Signed-off-by: Peter M <petermm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to update the build task to use ATOMVM_ELIXIR_SUPPORT, removed legacy support (copying/changing partition map etc), as to avoid code complexity/branches..
tested locally:
mix atomvm.esp32.build --chip esp32s3 --mbedtls-prefix /opt/homebrew/opt/mbedtls@3 --atomvm-path ../../AtomVMmix atomvm.esp32.build --chip esp32s3 --mbedtls-prefix /opt/homebrew/opt/mbedtls@3 --atomvm-path ../../AtomVM --cleanmix atomvm.esp32.build --use-docker --chip esp32s3 --mbedtls-prefix /opt/homebrew/opt/mbedtls@3mix atomvm.esp32.build --chip esp32s3 --mbedtls-prefix /opt/homebrew/opt/mbedtls@3