refactor(desktop): split pty_host.go out of paste_image.go - #320
Merged
Conversation
`desktopPtyHost` is the desktop-side adapter that satisfies the relay's ptyhost.PtyHost / ImagePasteHost / FilePasteHost interfaces. It lived inside paste_image.go by accident of who first needed it — but the struct itself, its Write override, and its PTY-input debug logging are shared with paste_file.go and are not image-paste concerns. Move the struct + Write + ptyInputDebugTag + logPtyInput into a new desktop/pty_host.go. PasteImage stays in paste_image.go alongside its savePastedImage / native clipboard implementations — same split as paste_file.go already has for PasteFile. Net: same code, split by responsibility. `go test ./desktop/...` green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`desktopPtyHost` is the desktop-side adapter that satisfies the relay's `ptyhost.PtyHost` / `ImagePasteHost` / `FilePasteHost` interfaces. It lived inside `paste_image.go` by accident of who first needed it — but the struct itself, its `Write` override, and its PTY-input debug logging are shared with `paste_file.go` and are not image-paste concerns.
Move the struct + `Write` + `ptyInputDebugTag` + `logPtyInput` into a new `desktop/pty_host.go`. `PasteImage` stays in `paste_image.go` alongside its `savePastedImage` / native-clipboard implementations — same split as `paste_file.go` already has for `PasteFile`.
Net: same code, split by responsibility.
Test plan