refactor(ptyhost): move PtyHost + ImagePasteHost + FilePasteHost interfaces - #322
Merged
Conversation
…rfaces The three interfaces have always described "what a PTY-owning host must implement to be adopted by the relay". They lived in internal/relay/adopt.go by history — but they're not relay-specific types; they're the abstract contract for anything that owns a PTY-like byte stream (a real OS PTY, an SSH channel, a browser bridge, a test double). Move to internal/ptyhost/interfaces.go alongside the concrete Host struct they were shadowing. adopt.go now imports internal/ptyhost and qualifies as ptyhost.PtyHost / ptyhost.ImagePasteHost / ptyhost.FilePasteHost. - adopt.go: drop the three type decls; import ptyhost; update the AdoptSession(host ptyhost.PtyHost) signature and the two type assertions on paste-capable adapters. - No consumer names the types explicitly (desktopPtyHost / sshPtyHost satisfy them structurally). The interfaces are moved, not renamed; any adapter compiled before this change still satisfies them. - adopt_test.go only mentions the names in comments — no code change. `go test ./internal/... ./desktop/...` green (relay + desktop suites including AdoptSession round-trips).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Milestone 6-d. The three interfaces have always described "what a PTY-owning host must implement to be adopted by the relay". They lived in `internal/relay/adopt.go` by history — but they're not relay-specific types; they're the abstract contract for anything that owns a PTY-like byte stream (a real OS PTY, an SSH channel, a browser bridge, a test double).
Move to `internal/ptyhost/interfaces.go` alongside the concrete `Host` struct they were shadowing. `adopt.go` now imports `internal/ptyhost` and qualifies as `ptyhost.PtyHost` / `ptyhost.ImagePasteHost` / `ptyhost.FilePasteHost`.
Changes:
Test plan