refactor(frontend): extract touchScrollDebug helpers from TerminalView.vue - #325
Merged
Conversation
…w.vue First slice of milestone 5-b. TerminalView.vue is a 2700-line SFC and the touch-scroll debug plumbing was ~50 lines of module-scoped state (ring buffer + enabled flag) and helpers (readTouchDebugFlag, logTouch, installTouchDebugDump) that had nothing to do with the terminal setup around them — they existed only to instrument the touch/scroll code paths across the file. Move to lib/touchScrollDebug.ts. touchState() stays inline because it closes over reactive refs (selectionMode / imeFocused / softKeyboardOpen / keyboardWanted / userScrolledDuringKeyboardCycle) that only exist inside setup. Exports: readTouchDebugFlag, setTouchDebugEnabled, isTouchDebugEnabled, logTouch, installTouchDebugDump. The enable flag flip becomes explicit at the call site (setTouchDebugEnabled(readTouchDebugFlag())) instead of the direct `touchDebugEnabled = readTouchDebugFlag()` module-var mutation. logTouch keeps its "no-op when disabled" behavior; three call sites that guarded on the raw variable now use isTouchDebugEnabled(). Behavior is byte-identical: same localStorage key, same ring size (300), same `[tsc]` console prefix, same window.__attermTouchDebug() dump. `npm test` 1631/1631; `npm run build` green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice of milestone 5-b. TerminalView.vue is a 2700-line SFC and the touch-scroll debug plumbing was ~50 lines of module-scoped state (ring buffer + enabled flag) and helpers (`readTouchDebugFlag`, `logTouch`, `installTouchDebugDump`) that had nothing to do with the terminal setup around them — they existed only to instrument the touch/scroll code paths across the file.
Move to `lib/touchScrollDebug.ts`. `touchState()` stays inline because it closes over reactive refs (`selectionMode` / `imeFocused` / `softKeyboardOpen` / `keyboardWanted` / `userScrolledDuringKeyboardCycle`) that only exist inside setup.
Exports: `readTouchDebugFlag`, `setTouchDebugEnabled`, `isTouchDebugEnabled`, `logTouch`, `installTouchDebugDump`. The enable flag flip becomes explicit at the call site (`setTouchDebugEnabled(readTouchDebugFlag())`) instead of the direct `touchDebugEnabled = readTouchDebugFlag()` module-var mutation. `logTouch` keeps its "no-op when disabled" behavior; three call sites that guarded on the raw variable now use `isTouchDebugEnabled()`.
Behavior is byte-identical: same localStorage key, same ring size (300), same `[tsc]` console prefix, same `window.__attermTouchDebug()` dump.
Test plan