fix: preserve false value for default_head_tags_disabled in screen renderer update(ghIssue 1413)#1416
Open
harshithRai wants to merge 2 commits into
Open
fix: preserve false value for default_head_tags_disabled in screen renderer update(ghIssue 1413)#1416harshithRai wants to merge 2 commits into
harshithRai wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
- Coverage 80.34% 80.33% -0.02%
==========================================
Files 156 156
Lines 7225 7225
Branches 1595 1595
==========================================
- Hits 5805 5804 -1
Misses 762 762
- Partials 658 659 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Fix
default_head_tags_disabledbeing silently ignored when set to false in screen renderer settings. The field uses the||operator which coercesfalsetoundefined, causing it to be omitted from the Management API request body. Changed to??(nullish coalescing) so that onlynull/undefinedfall back, preserving explicitfalsevalues.This means once
default_head_tags_disabled: truewas deployed, it could never be reverted to false via the CLI.📚 References
fixes #1413
🔬 Testing
test/tools/auth0/handlers/prompts.tests.tsthat callsupdateScreenRendererwithdefault_head_tags_disabled: falseand asserts the captured API payload contains false (not undefined). This test fails on the original code and passes after the fix.📝 Checklist