fix(example): set Redis TTL on session keys using absoluteDuration - #54
Open
frederikprijck wants to merge 1 commit into
Open
fix(example): set Redis TTL on session keys using absoluteDuration#54frederikprijck wants to merge 1 commit into
frederikprijck wants to merge 1 commit into
Conversation
Without EX, sessions persist indefinitely in Redis even after the SDK considers them expired. Compute remaining TTL from createdAt + absoluteDuration - now so keys expire at the correct wall-clock time. Apply the same TTL to the sid index key. Thread absoluteDuration through the store factory so the Redis TTL stays in sync with sessionConfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set()in the Redis store example had noEXoption, so session keys persisted indefinitely even after the SDK considered them expiredcreatedAt + absoluteDuration - nowso keys expire at the correct wall-clock time regardless of how many times the session is writtenlogout:sid:<sid>index keyabsoluteDurationthroughcreateRedisSessionStore(defaulting to the SDK's own default of 3 days) so the Redis TTL stays in sync withsessionConfiguration