Skip to content

feat(core, react): add scim token create form with scope selection - #588

Draft
chakrihacker wants to merge 1 commit into
mainfrom
feat/UIC-1631-1632-scim-token-form
Draft

chakrihacker wants to merge 1 commit into
mainfrom
feat/UIC-1631-1632-scim-token-form

Conversation

@chakrihacker

Copy link
Copy Markdown
Contributor

Summary

Replace the hardcoded 3600s token generation with a create-token form in the SSO provisioning tab. Users can now set a token lifetime or pick no expiration, and choose which SCIM scopes the token gets.

  • core: add the provisioning create-token zod schema, with a 900s minimum lifetime and an optional max from the Connection Profile
  • core: add SCIM token constants, mappers and i18n strings (en-US, fr, ja)
  • react: add ProvisioningCreateTokenForm and a two-step create-token modal (form first, then the generated token)
  • react: read the SCIM token config from the Connection Profile via useIdpConfigService.getScimTokenConfig
  • react: show the expiry date, scopes and created date on each token in the manage-token list

Why

What

Packages

  • packages/core
  • packages/react
  • examples

References

Testing

How can this be verified? Note anything intentionally not covered by tests and why.

  • This change adds unit test coverage
  • Tested for both SPA and RWA flows, all example apps working
  • All existing and new tests complete without errors

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

Replace the hardcoded 3600s token generation with a create-token form in the
SSO provisioning tab. Users can now set a token lifetime or pick no
expiration, and choose which SCIM scopes the token gets.

- core: add the provisioning create-token zod schema, with a 900s minimum
  lifetime and an optional max from the Connection Profile
- core: add SCIM token constants, mappers and i18n strings (en-US, fr, ja)
- react: add ProvisioningCreateTokenForm and a two-step create-token modal
  (form first, then the generated token)
- react: read the SCIM token config from the Connection Profile via
  useIdpConfigService.getScimTokenConfig
- react: show the expiry date, scopes and created date on each token in the
  manage-token list
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.07121% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.60%. Comparing base (ac4e29b) to head (0f0ede4).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...g-create-token/provisioning-create-token-modal.tsx 96.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   91.29%   91.60%   +0.30%     
==========================================
  Files         258      263       +5     
  Lines       19952    20289     +337     
  Branches     2962     3040      +78     
==========================================
+ Hits        18215    18585     +370     
+ Misses       1737     1704      -33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants