Repository navigation
feat(core, react): add scim token create form with scope selection - #588
Draft
chakrihacker wants to merge 1 commit into
Draft
chakrihacker wants to merge 1 commit into
chakrihacker wants to merge 1 commit into
Conversation
Replace the hardcoded 3600s token generation with a create-token form in the SSO provisioning tab. Users can now set a token lifetime or pick no expiration, and choose which SCIM scopes the token gets. - core: add the provisioning create-token zod schema, with a 900s minimum lifetime and an optional max from the Connection Profile - core: add SCIM token constants, mappers and i18n strings (en-US, fr, ja) - react: add ProvisioningCreateTokenForm and a two-step create-token modal (form first, then the generated token) - react: read the SCIM token config from the Connection Profile via useIdpConfigService.getScimTokenConfig - react: show the expiry date, scopes and created date on each token in the manage-token list
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 91.29% 91.60% +0.30%
==========================================
Files 258 263 +5
Lines 19952 20289 +337
Branches 2962 3040 +78
==========================================
+ Hits 18215 18585 +370
+ Misses 1737 1704 -33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the hardcoded 3600s token generation with a create-token form in the SSO provisioning tab. Users can now set a token lifetime or pick no expiration, and choose which SCIM scopes the token gets.
Why
What
Packages
packages/corepackages/reactexamplesReferences
Testing
How can this be verified? Note anything intentionally not covered by tests and why.
Checklist
Contributing