Shimmer implemented on Authenticator screen#45
Open
Sudhanshu96 wants to merge 2 commits into
Open
Conversation
Contributor
|
@Sudhanshu96 Detekt failed. Some Lint issues |
pacific-ring
reviewed
Jul 2, 2026
pmathew92
reviewed
Jul 2, 2026
pmathew92
reviewed
Jul 2, 2026
| - 💬 **SMS OTP** - Phone number verification via one-time codes | ||
| - 📧 **Email OTP** - Email-based verification | ||
| - 🔑 **Recovery Codes** - Backup authentication codes for account recovery | ||
| - ✨ **Skeleton shimmer loading** - Card screens show animated, theme-aware skeleton placeholders while data loads (light/dark mode, honours the system animation setting) |
Contributor
There was a problem hiding this comment.
Not required. Shimmer effect is more of a cosmetic change
pmathew92
reviewed
Jul 2, 2026
pacific-ring
reviewed
Jul 2, 2026
| @Composable | ||
| internal fun animationsEnabled(): Boolean { | ||
| val context = LocalContext.current | ||
| val scale = Settings.Global.getFloat( |
Contributor
There was a problem hiding this comment.
can we avoid syncronous call to Setting.Global.getFloat
this can induce Jank. Need to check on this :
Contributor
|
Also @Sudhanshu96 I think something is wrong here. I can see my commits in this PR as well. Can you check once |
Sudhanshu96
force-pushed
the
feature/shimmer_loading_effect
branch
from
28226d9 to
724a2e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the spinner-based loading states on the auth-method card screens with a reusable, theme-aware skeleton shimmer system. Placeholders mirror the loaded layout, so there's no layout shift when data arrives, and the loading state reads more clearly than a centered spinner.
Type of Change
📹 Video
Dark Mode
https://github.com/user-attachments/assets/757c4e9e-f56e-4221-8587-8d3fe96cdd4e
Light Mode
https://github.com/user-attachments/assets/3fe2c8f6-07b2-4d9f-9e7b-9333fc05b2e6
appropriate)
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors