Added bottomsheet support for SMS, Phone number and Authenticator flows instead of full screen sheet#15
Open
Sudhanshu96 wants to merge 6 commits intomainfrom
Open
Added bottomsheet support for SMS, Phone number and Authenticator flows instead of full screen sheet#15Sudhanshu96 wants to merge 6 commits intomainfrom
Sudhanshu96 wants to merge 6 commits intomainfrom
Conversation
…ws instead of full screen sheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
OTP entry is now a bottom sheet instead of a full-screen push.
Every enrollment flow that previously navigated to an .otpScreen route now presents OTPView as a modal bottom sheet.
The parent screen stays visible and dimmed behind the sheet.
📹 Video
bottomsheet_implementation.mov