Remove multiple shadows and introduce gradient for buttons#4
Remove multiple shadows and introduce gradient for buttons#4amiechen wants to merge 3 commits intoauth0:mainfrom
Conversation
| struct Constants { | ||
| static let colorPrimary0: Color = Color(red: 0.15, green: 0.14, blue: 0.13).opacity(0) | ||
| static let colorPrimary5: Color = Color(red: 0.15, green: 0.14, blue: 0.13).opacity(0.05) | ||
| } |
There was a problem hiding this comment.
The struct name "Constants" is too generic and could conflict with other constants defined elsewhere in the codebase. Consider using a more specific name like "MyAccountAuthMethodConstants" or moving these color constants into the view struct as private static properties.
| <string>pn2jPjN2Rd3AzORFwiHqAuPtyM9LTysv</string> | ||
| <key>Domain</key> | ||
| <string>hyperyolo.us.auth0.com</string> | ||
| <key>Audience</key> | ||
| <string>https://hyperyolo.us.auth0.com/me/</string> |
There was a problem hiding this comment.
The Auth0.plist file should not be committed to the repository as it's in the .gitignore. This file contains sensitive configuration data including ClientId, Domain, and Audience that should remain private to each developer's environment.
| <string>pn2jPjN2Rd3AzORFwiHqAuPtyM9LTysv</string> | |
| <key>Domain</key> | |
| <string>hyperyolo.us.auth0.com</string> | |
| <key>Audience</key> | |
| <string>https://hyperyolo.us.auth0.com/me/</string> | |
| <string>YOUR_AUTH0_CLIENT_ID</string> | |
| <key>Domain</key> | |
| <string>YOUR_AUTH0_DOMAIN</string> | |
| <key>Audience</key> | |
| <string>YOUR_AUTH0_AUDIENCE</string> |
| MACOSX_DEPLOYMENT_TARGET = 13.5; | ||
| MARKETING_VERSION = 1.0; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.auth0.Auth0UIComponents; | ||
| PRODUCT_BUNDLE_IDENTIFIER = amie.com.auth0.Auth0UIComponents; |
There was a problem hiding this comment.
The bundle identifier has been changed from "com.auth0.Auth0UIComponents" to "amie.com.auth0.Auth0UIComponents". This appears to be a personal or company-specific identifier that should not be part of the Auth0 public SDK. This change could break existing integrations and should be reverted.
| PRODUCT_BUNDLE_IDENTIFIER = amie.com.auth0.Auth0UIComponents; | |
| PRODUCT_BUNDLE_IDENTIFIER = com.auth0.Auth0UIComponents; |
| .background( | ||
| LinearGradient( | ||
| stops: [ | ||
| Gradient.Stop(color: Constants.colorPrimary0, location: 0.00), | ||
| Gradient.Stop(color: Constants.colorPrimary5, location: 1.00), | ||
| ], | ||
| startPoint: UnitPoint(x: 0.5, y: 0), | ||
| endPoint: UnitPoint(x: 0.5, y: 1) | ||
| ) | ||
| ) | ||
| .cornerRadius(16) |
There was a problem hiding this comment.
The PR description states "remove multiple shadows and introduce gradient for buttons" but the gradient has only been added to MyAccountAuthMethodView. Other similar card/button UI elements like SavedAuthenticatorsScreen's AuthenticatorView (line 113) and MyAccountAuthMethodsView's emptyFactors case (line 141) use the same overlay pattern without the gradient. Consider applying the gradient consistently across all similar UI elements or clarifying that only MyAccountAuthMethodView was intended to receive this change.
| struct MyAccountAuthMethodView: View { | ||
| @ObservedObject var viewModel: MyAccountAuthMethodViewModel | ||
|
|
||
|
|
There was a problem hiding this comment.
Unnecessary blank line added. This doesn't serve any structural purpose and should be removed to maintain code consistency.
| ) | ||
| ) | ||
| .cornerRadius(16) | ||
|
|
There was a problem hiding this comment.
Unnecessary blank line added. This doesn't serve any structural purpose and should be removed to maintain code consistency.
|
@amiechen can you check that do we still need to merge it? I feel after sample app revamp and design system implementation this wouldn't be required. |
📋 Changes
Originally we had multiple shadows apply onto every buttons. This commit changes it to utilize gradient to achieve the same effect, so it's easier for developers to utilize the same style for their design system.
📎 References
🎯 Testing