feat: rest + grpc for orgs, SSO, SCIM, org domains; full protocol coverage - #25
Merged
Merged
Conversation
…erage 26 admin methods were gqlOnly because the server had no RPC for them. Server 2.4.0 (authorizer #739) added the proto RPCs and REST bindings for organizations, org members, org domains, org OIDC/SAML connections and SCIM endpoints, so they now span all three protocols. A further 5 -- AdminLogout, AdminSession, AdminMeta, FgaGetModel and FgaReset -- were rest+grpc-only despite each having a GraphQL op on the server; the SDK simply carried no query for them. That leaves AdminSignup, UpdateEnv and GenerateJWTKeys graphql-only, the only admin operations with no proto RPC. Not a breaking change: the 26 keep their hand-written request/response types. Those return the bare domain object while the proto response wraps it, so adminMethodSpec gains responseUnwrap -- the dual of the existing graphqlWrap. AdminMeta and FgaGetModel need the opposite, since their proto responses nest while the GraphQL ops return the object directly. REST for these decodes into the proto message first, via the new restResponse. grpc-gateway emits int64 as a JSON string and doREST only applies protojson to proto.Message targets, so decoding straight into a domain type failed on every timestamp. A wrong unwrap yields a zero-valued struct rather than an error, so the new cross-protocol tests assert real field values. Requires authorizer-proto-go v0.2.0-rc.0. Integration tests now run against the 2.4.0-rc.13 image.
lakhansamani
force-pushed
the
feat/rest-grpc-parity-2.4.0
branch
from
August 2, 2026 05:01
3bb6fec to
eea19f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the SDK to full protocol coverage against server 2.4.0.
What changed
26 admin methods that were
gqlOnlygained proto RPCs and REST bindings in authorizer #739 — organizations, org members, org domains, org OIDC/SAML connections and SCIM endpoints.A further 5 —
AdminLogout,AdminSession,AdminMeta,FgaGetModel,FgaReset— were rest+grpc-only despite each having a GraphQL op on the server. All now span three protocols, leavingAdminSignup,UpdateEnvandGenerateJWTKeysgraphql-only (no proto RPC exists for them).Not a breaking change
The 26 keep their hand-written request/response types. Those signatures return the bare domain object while the proto response wraps it, so
adminMethodSpecgainsresponseUnwrap— the dual of the existinggraphqlWrap.AdminMeta/FgaGetModelneed the opposite (graphqlWrap), since their proto responses nest while the GraphQL ops return the object directly.A wrong unwrap yields a zero-valued struct rather than an error, so the tests assert real field values over every protocol. Mutation-tested: clearing
CreateOrganization's unwrap fails rest and grpc while graphql still passes.REST for these decodes into the proto message first, via the new
restResponse. grpc-gateway emits int64 as a JSON string anddoRESTonly applies protojson toproto.Messagetargets, so decoding straight into a domain type failed on every timestamp.Three pre-existing bugs fixed
ListOrganizationsRequest,ListOrgMembersRequestandListOrgDomainsRequesttyped their pagination field asPaginatedRequest, itself a{pagination:{...}}envelope, so the payload nested pagination twice and the server ignored it._verification_requests,_webhooksand_email_templatesdeclared$data: PaginatedRequest, a type the schema does not define — all three failed over graphql withUnknown type.Verification
Full suite green against a live 2.4.0 server, including new cross-protocol tests for the org surface and the admin-meta surface.
go vetclean.Depends on authorizer-proto-go v0.2.0-rc.0 (released); the local replace is dropped.