fix: AUTHORIZER_URL is required in 2.4.0 - #7
Merged
Conversation
#764 made --url mandatory in Authorizer 2.4.0 — the server exits at boot without it. This deploy path passed the flag but treated the value as optional, so a default deploy produces a server that will not start. app.json had required:false, so the one-click deploy left it empty. Also documents it in the required-variables table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
authorizerdev/authorizer#764 made
--urlmandatory in Authorizer 2.4.0 —validateAuthorizerURLrefuses startup without it. This deploy path already passed the flag, but treated the value as optional, so a default deploy produces a server that exits at boot.Without
--urlthe server derives its own host from request headers, so a forgedHostmakes a genuine password-reset link point at an attacker-controlled domain (CWE-640). Mandatory is the fix; these repos had not caught up.Related
--urlbecoming mandatory authorizer#766 — records the breaking change in the changelog--urlhelp still said it was optional authorizer#767 — the flag's own help text said it was optional too--urlas required docs#88 — 22 of 24 doc pages with a runnable command omitted itThis repo
app.jsonhad"required": false, so the one-click deploy button left it empty and the dyno failed to boot. Nowrequired: true, with a description naming the app-name-derived value and stating that the server exits without it. Added to the README's required-variables table.app.jsonvalidated as JSON.