chore!: regenerate stubs for id-only DeleteUser - #3
Merged
Conversation
Pulled from BSR after authorizerdev/authorizer#753. DeleteUserRequest.Email is replaced by DeleteUserRequest.Id; proto field 1 is reserved rather than reused, so an old client's email cannot silently decode as an id on a delete. Most of the admin.pb.go diff is the embedded raw file descriptor, not generated Go — no protoc-gen-go version change is involved. BREAKING CHANGE: DeleteUserRequest.Email and GetEmail() are removed; use Id and GetId(). Requires server 2.4.0+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated from BSR (
make generate) after authorizerdev/authorizer#753 landed and the push-to-BSR job published the new schema. No hand-edits.Change
Plus the service comment on
DeleteUserinadmin_grpc.pb.go.Email is not an identifier every account has — a phone-only signup has none — so an email-keyed delete could not reach those accounts at all.
On the diff size
admin.pb.goshows ~3983 changed lines. Almost all of it is the embedded raw file descriptor, which is a serialized blob that reflows on any schema change. I checked for aprotoc-gen-goversion bump in the diff — there is none, so this is not toolchain churn. The generated Go surface changes by exactly the four lines above.BREAKING
DeleteUserRequest.EmailandGetEmail()are removed. UseId/GetId(). Requires server 2.4.0+.Field 1 is reserved rather than reused:
emailandidare both strings, so reusing tag 1 would let an old client's email decode silently as an id — wire-compatible, semantically wrong, and pointed at a delete. Reserving makes an old client fail loudly instead.Verified
make generate(clean),make build,make vetall exit 0.Needs a tag after merge —
authorizer-gopinsv0.2.0-rc.0and cannot take this until it is released.