Skip to content

chore!: regenerate stubs for id-only DeleteUser - #3

Merged
lakhansamani merged 1 commit into
mainfrom
chore/regen-delete-user-id
Aug 7, 2026
Merged

chore!: regenerate stubs for id-only DeleteUser#3
lakhansamani merged 1 commit into
mainfrom
chore/regen-delete-user-id

Conversation

@lakhansamani

Copy link
Copy Markdown
Contributor

Regenerated from BSR (make generate) after authorizerdev/authorizer#753 landed and the push-to-BSR job published the new schema. No hand-edits.

Change

-  Email string `protobuf:"bytes,1,opt,name=email,proto3"`
+  Id    string `protobuf:"bytes,2,opt,name=id,proto3"`

-func (x *DeleteUserRequest) GetEmail() string
+func (x *DeleteUserRequest) GetId() string

Plus the service comment on DeleteUser in admin_grpc.pb.go.

Email is not an identifier every account has — a phone-only signup has none — so an email-keyed delete could not reach those accounts at all.

On the diff size

admin.pb.go shows ~3983 changed lines. Almost all of it is the embedded raw file descriptor, which is a serialized blob that reflows on any schema change. I checked for a protoc-gen-go version bump in the diff — there is none, so this is not toolchain churn. The generated Go surface changes by exactly the four lines above.

BREAKING

DeleteUserRequest.Email and GetEmail() are removed. Use Id / GetId(). Requires server 2.4.0+.

Field 1 is reserved rather than reused: email and id are both strings, so reusing tag 1 would let an old client's email decode silently as an id — wire-compatible, semantically wrong, and pointed at a delete. Reserving makes an old client fail loudly instead.

Verified

make generate (clean), make build, make vet all exit 0.

Needs a tag after merge — authorizer-go pins v0.2.0-rc.0 and cannot take this until it is released.

Pulled from BSR after authorizerdev/authorizer#753. DeleteUserRequest.Email
is replaced by DeleteUserRequest.Id; proto field 1 is reserved rather than
reused, so an old client's email cannot silently decode as an id on a delete.

Most of the admin.pb.go diff is the embedded raw file descriptor, not
generated Go — no protoc-gen-go version change is involved.

BREAKING CHANGE: DeleteUserRequest.Email and GetEmail() are removed; use Id
and GetId(). Requires server 2.4.0+.
@lakhansamani
lakhansamani merged commit 8b2dce6 into main Aug 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant