fix(site): getting-started still described v1 configuration - #25
Merged
Conversation
Step 2 told users to "Configure environment variables from dashboard". v2 removed both halves of that: configuration is CLI-flags only (no .env, no OS env vars), and the dashboard cannot update server config at all. Following it, a user deploys, opens the dashboard, and finds nothing to configure — after the server has already refused to start without --url and --encryption-key.
✅ Deploy Preview for authorizer-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Step 2 of the homepage's Getting Started read:
v2 removed both halves of that:
.envor OS env vars_update_envreturns an error)Both are listed as BREAKING in the v2 changelog. So a user following this deploys, opens the dashboard looking for the settings screen, and finds nothing — assuming they got that far, since the server now refuses to start without
--urland--encryption-key, which the step never mentions.What
Rewrites the step to say configuration happens at startup, and names the flags that are actually required.
npx tsc --noEmitclean.Related
Companion to #24, which adds
--urlto the homepage copy command. Same root cause: site copy not swept when required flags changed.