Skip to content

Fix/azure access data actions rebased - #98

Merged
amansingh39 merged 2 commits into
authsec-stagingfrom
fix/azure-access-data-actions-rebased
Oct 23, 2026
Merged

amansingh39 merged 2 commits into
authsec-stagingfrom
fix/azure-access-data-actions-rebased

Conversation

@ritamAN77

Copy link
Copy Markdown
Contributor

Description

Changes

Testing

  • Unit tests pass (go test -short ./tests/unit/)
  • go vet ./... clean
  • Manual testing (describe below)
  • Add label run-integration to this PR to trigger integration tests in CI (requires a live DB)

Checklist

  • Code follows the project's style guidelines
  • Self-reviewed the diff
  • No secrets or credentials committed
  • Updated documentation if needed
  • Added/updated tests for new behaviour

amansingh39 and others added 2 commits October 23, 2026 14:29
…lt, Service Bus, Event Hubs)

A block on a Foundry project's identity left its agent answering: the agent
reads an Azure AI Search index with Search Index Data Reader, a role with
data actions only, and a block outside storage accounts looked at management
actions only.

azureActions now adds the data actions (and key listings) of AI Search, Key
Vault secrets, Service Bus and Event Hubs; an allow assigns Search Index
Data Reader/Contributor and Key Vault Secrets User/Officer there. Storage
accounts and every other resource type are unchanged. The preview notes AI
Search API keys and Key Vault access policies, which role assignments do
not cover.

Tests: TestAzureActions*, TestAzureBlockReachesSearchIndexData,
TestAzureAllowAssignsDataRoles, TestAzureDataPlaneChildTypes,
TestAccessPolicyAzureSearchIndex. Existing Azure and AWS access-policy
tests still pass.
…a role

Reader and Contributor reach no message, so an allow there read Active
while the identity still could not send or receive. An allow now assigns
Azure Service Bus / Event Hubs Data Receiver (read), Data Sender (write),
or Data Owner (read and write).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@amansingh39
amansingh39 merged commit ab46c4d into authsec-staging Oct 23, 2026
4 of 5 checks passed
apauthnull pushed a commit that referenced this pull request Oct 24, 2026
Staging's PR #98 added an Azure data-plane table (AI Search, Key Vault,
Service Bus, Event Hubs) under the same names as this branch's fuller one
in services/iga_gov_access_azure_planes.go. Resolution:
- keep this branch's table; drop the duplicate type, table, lookup,
  azureActions addition and per-type note from iga_gov_access_azure.go;
- adopt #98's allow of read and write on Service Bus / Event Hubs:
  Data Owner (bothRole), with a preview warning that it also manages
  the namespace (this branch had refused it);
- role constants: this branch's plus #98's two Data Owner roles;
- #98's unit tests adapted where this branch deliberately differs (a
  storage account block covers every data service and SAS path; a mapped
  type's read is its data and key actions, not the management read); its
  integration test runs unchanged;
- docs/PROGRESS.md keeps both histories.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants