Skip to content

Fix the stale-read flake in TestRunnerAuthz_ReadonlyAllow #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephschorr merged 1 commit into from
Oct 1, 2026
Merged

Fix the stale-read flake in TestRunnerAuthz_ReadonlyAllow #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/authz/spicedb/toolcheck/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func TestRunnerAuthz_ReadonlyAllow(t *testing.T) {
defer cancel()

// Grant alice reader on repo:foo.
_, err := perm.WriteRelationships(ctx, &v1.WriteRelationshipsRequest{
wresp, err := perm.WriteRelationships(ctx, &v1.WriteRelationshipsRequest{
Updates: []*v1.RelationshipUpdate{{
Operation: v1.RelationshipUpdate_OPERATION_TOUCH,
Relationship: &v1.Relationship{
Expand All @@ -104,7 +104,16 @@ func TestRunnerAuthz_ReadonlyAllow(t *testing.T) {
})
require.NoError(t, err, "WriteRelationships")

res := toolcheck.Checker{Cli: cli}.CheckToolCall(ctx,
// Floor the check at the write above. A cacheless Checker checks at
// MinimizeLatency, which is free to serve a quantized snapshot that
// predates the write (see the consistency notes in CheckToolCall) —
// correct in production, but here it intermittently turns this allow
// into a deny. What this test claims is the readonly allow path, not
// floorless freshness, so pin the revision like production callers do.
cache := toolcheck.NewZedTokenCache()
cache.Set("github_repo", "foo", wresp.WrittenAt.Token)

res := toolcheck.Checker{Cli: cli, Cache: cache}.CheckToolCall(ctx,
authz.Permission{
StateImpact: authz.Readonly,
Check: &authz.PermissionCheck{
Expand Down
Loading