Fix: Replace Blocking Alert with Professional Timer Warning System#70
Open
ChinmayOnGithub wants to merge 1 commit into
Open
Fix: Replace Blocking Alert with Professional Timer Warning System#70ChinmayOnGithub wants to merge 1 commit into
ChinmayOnGithub wants to merge 1 commit into
Conversation
- Remove alert() that froze game at 10 seconds - Add smooth pulsing timer and bar
Author
|
@avinash201199 Can you look into this one as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
Description
This PR addresses the blocking alert issue that occurs when the game timer reaches 10 seconds. The current implementation uses a browser
alert()which freezes the entire game and blocks all user interactions. While the timer pauses during the alert, players cannot interact with the cards, creating a poor user experience and disrupting the game flow.Solution
Replaced the blocking alert with a professional, non-blocking visual warning system that provides clear feedback without interrupting gameplay:
Screenshots
Technical Implementation
Files Modified:
src/js/app.js- Timer warning logic and cleanup handlerssrc/css/styles.css- Visual effects and animationsKey Changes:
alert()call at line 180stopTimer()andresetTimer()functionsCode Statistics:
Testing Performed
Benefits
Hacktoberfest 2025
Please accept this PR under
hacktoberfestlabel.