Skip to content

Parse wrapped Linux apksigner output #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awatchar merged 2 commits into from
Aug 13, 2026
Merged

Parse wrapped Linux apksigner output #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b32cdb
Parse wrapped Linux apksigner output
awatchar Aug 13, 2026
841ac6f
Fix PowerShell 5.1 ANSI fixture
awatchar Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/update-minimum-device.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,12 @@ function Find-ApkSignerInSdkRoots {

function Parse-ApkSignerOutput {
param([string]$Text)
$digests = @([regex]::Matches($Text,
'(?im)^Signer #\d+ certificate SHA-256 digest:\s*([0-9a-f]{64})\s*$') |
# PowerShell 7 wraps some extensionless native-command output as ErrorRecord text on Linux,
# which can prefix the original line. Strip terminal control sequences and locate the exact
# apksigner label without requiring it to begin the rendered PowerShell line.
$normalized = [regex]::Replace($Text, '\x1B\[[0-?]*[ -/]*[@-~]', '')
$digests = @([regex]::Matches($normalized,
'(?i)Signer #\d+ certificate SHA-256 digest:\s*([0-9a-f]{64})(?![0-9a-f])') |
ForEach-Object { $_.Groups[1].Value.ToUpperInvariant() })
if ($digests.Count -eq 0) {
Throw-UpdateError "APK_SIGNATURE_INVALID" "apksigner did not report a verified signing certificate."
Expand Down
3 changes: 3 additions & 0 deletions tests/update-minimum-device.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ Test-Case "returning target switches to its correlated ADB port" {
Test-Case "apksigner output parser requires verified signer digest" {
$digest = "168F42ED412DA80ADAF27BED0984DBEE191168E9DF04F08AFA240A3F9DE45972"
Assert-Equal $digest (Parse-ApkSignerOutput "Signer #1 certificate SHA-256 digest: $digest") "apksigner digest"
$escape = [char]27
$linuxWrapped = "NativeCommandError: ${escape}[36mSigner #1 certificate SHA-256 digest: $($digest.ToLowerInvariant())${escape}[0m"
Assert-Equal $digest (Parse-ApkSignerOutput $linuxWrapped) "PowerShell Linux wrapped digest"
Assert-ThrowsCode { Parse-ApkSignerOutput "DOES NOT VERIFY" } "APK_SIGNATURE_INVALID" "missing signer digest"
}

Expand Down
Loading