Skip to content

Pass exact argv to Linux apksigner - #17

Merged
awatchar merged 5 commits into
mainfrom
fix/apksigner-exact-argv
Aug 13, 2026
Merged

Pass exact argv to Linux apksigner#17
awatchar merged 5 commits into
mainfrom
fix/apksigner-exact-argv

Conversation

@awatchar

Copy link
Copy Markdown
Owner

Root cause

Release run 31730892695 proved the signed APK and Bash signature/identity checks pass, then the strengthened PowerShell test failed because the extensionless Linux launcher received one reparsed Arguments string. The adversarial .bat fixture also checked ComSpec before rejecting an unsafe percent path.

Fix

  • use ProcessStartInfo.ArgumentList for exact argv on .NET Core/Linux
  • retain the reviewed quoted Arguments fallback for Windows PowerShell 5.1
  • reject unsafe .bat paths before platform/ComSpec availability
  • run the full updater suite against the real Linux debug APK/apksigner in ordinary PR and main CI, deriving exact expected identity from aapt

Local verification

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
minimum Ignored Ignored Aug 13, 2026 6:56pm

@awatchar
awatchar merged commit 192ee37 into main Aug 13, 2026
4 checks passed
@awatchar
awatchar deleted the fix/apksigner-exact-argv branch August 13, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant