Fix Windows build failure in rotator module#24
Merged
aweeri merged 3 commits intoaweeri:mainfrom Mar 21, 2026
Merged
Conversation
sandrwich
force-pushed
the
fix/windows-rotator-build
branch
from
1532661 to
d16ab22
Compare
sandrwich
force-pushed
the
fix/windows-rotator-build
branch
from
d16ab22 to
b4145b5
Compare
Contributor
Author
|
Something odd happened with ImageMagick in MSYS2 and it now fails the .ico generation. It was using ImageMagick |
sandrwich
force-pushed
the
fix/windows-rotator-build
branch
from
b4145b5 to
5eb7b7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rotator.c build error: includes raylib.h (via rotator.h → ui.h) which defines
Rectangle,CloseWindow, andShowCursor. When it later includes<winsock2.h>, that pulls in<windows.h>→wingdi.h/winuser.hwhich redeclare those symbols with incompatible types. AddsWIN32_LEAN_AND_MEAN/NOGDI/NOUSER+LPMSGforward declaration, same pattern ui.c already uses.installer icon generation: uses
magick(IM7) withconvert(IM6) fallback, and generates multi-size icons withauto-resize. Ships a pre-generatedlogo.icoas final fallback for when ImageMagick is broken on CI (currently affected by a regression in IM 7.1.2-17 on MSYS2).