Skip to content

Conversation

@ConnorKirk
Copy link
Contributor

Issue number: closes #7927

Summary

Add ty type checker integration with baseline exclusions for incremental adoption:

Changes

  • Add ty check step to quality_check workflow (runs on all Python versions like mypy)
  • Configure ty exclusions for 14 modules with existing diagnostics
  • Add ty command to makefile

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2026
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes labels Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (7b93028) to head (3499e39).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7938   +/-   ##
========================================
  Coverage    96.72%   96.72%           
========================================
  Files          278      278           
  Lines        13607    13607           
  Branches      1080     1080           
========================================
  Hits         13162    13162           
  Misses         327      327           
  Partials       118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

)

Add ty type checker integration with baseline exclusions for incremental adoption:

- Add ty check step to quality_check workflow (runs on all Python versions like mypy)
- Configure ty exclusions for 14 modules with existing diagnostics
- Fix Makefile ty target indentation
@ConnorKirk ConnorKirk marked this pull request as ready for review January 9, 2026 14:42
@ConnorKirk ConnorKirk requested a review from a team as a code owner January 9, 2026 14:42
@leandrodamascena
Copy link
Contributor

I know it's ignoring a bunch of files yet, but look at this. Impressive how fast it is :D

image

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@leandrodamascena leandrodamascena merged commit 9dca23c into develop Jan 9, 2026
13 checks passed
@leandrodamascena leandrodamascena deleted the maintenance/add-ty branch January 9, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Add Ty type checker to CI with baseline exclusions

2 participants