chore: add make check-shell for the shell gate - #34
Merged
Conversation
The two self-check scripts need bash 4+, so running them locally on macOS meant knowing to type /opt/homebrew/bin/bash. Wraps the same three commands CI runs (#33) behind one target that picks a usable bash and can be overridden. Verified: make check-shell green; make check-shell BASH=/bin/bash surfaces the scripts' own 'needs bash 4+' guard instead of failing obscurely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #33. The shell gate now runs in CI, but running it locally still meant knowing that
scripts/check-*.shneed bash 4+ and that macOS/bin/bashis 3.2 — so in practice it meant typing/opt/homebrew/bin/bash scripts/check-deploy-config.shfrom memory.make check-shellwraps the same three commands CI runs, picking Homebrew's bash when present:Overridable with
make check-shell BASH=/path/to/bash.Verified
make check-shellgreen.make check-shell BASH=/bin/bashsurfaces the scripts' ownneeds bash 4+ (brew install bash)guard rather than failing obscurely on associative arrays.