fix(fabricator): require an architect or admin role to request fabrication - #170
Merged
Merged
Conversation
…ation requestAgentCreation and requestToolCreation now refuse callers that hold neither the architect nor the admin role, after the existing required organisation check and before anything is sent to the fabricator queue. Triggering fabrication drives model spend and creates agent records, so it is gated like the agent-code and import mutations. Supersedes the earlier in-code tenancy-only decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestAgentCreation/requestToolCreationrequire the architect or admin role (after the required-organisation check, before any SQS send), matching agent-code and import mutations.Follow-up to finding fac16c02 (#167).
Behaviour change
Verification
jest: 8095 passed, tsc clean; 5 new tests (reject non-architect before SQS, architect passes, admin passes, missing org still rejected first)