Repository navigation
Document the AbortIncompleteMultipartUpload lifecycle rule for write scatter - #90
Merged
Merged
Conversation
…scatter A write scatter creates its own multipart upload directly against the bucket, and the coordinating node holds the only upload ID. If that coordinator dies before it reaches its own unwind path, the client has no ID to abort the upload with, and the bucket keeps billing the orphaned parts until something else removes them. ADR-0032 and a code comment on coordinate::unwind already said the bucket needs an AbortIncompleteMultipartUpload lifecycle rule for exactly this case, but no user-facing doc did. Add that guidance to the install requirements and to the write-scatter design notes, with an example lifecycle configuration and a suggested expiry for both general-purpose (Standard) buckets and S3 Express One Zone directory buckets, and print a reminder in `helm install`'s NOTES.txt whenever the scatter resolves to enabled. A new chart test asserts the notice appears exactly when it should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the AbortIncompleteMultipartUpload lifecycle rule for write scatter
A write scatter creates its own multipart upload directly against the
bucket, and the coordinating node holds the only upload ID. If that
coordinator dies before it reaches its own unwind path, the client has no ID
to abort the upload with, and the bucket keeps billing the orphaned parts
until something else removes them. ADR-0032 and a code comment on
coordinate::unwind already said the bucket needs an
AbortIncompleteMultipartUpload lifecycle rule for exactly this case, but no
user-facing doc did.
Add that guidance to the install requirements and to the write-scatter
design notes, with an example lifecycle configuration and a suggested expiry
for both general-purpose (Standard) buckets and S3 Express One Zone
directory buckets, and print a reminder in
helm install's NOTES.txtwhenever the scatter resolves to enabled. A new chart test asserts the
notice appears exactly when it should.
Fix yamllint brace spacing in the write-scatter NOTES.txt test
Fixes #70